This repository was archived by the owner on Mar 19, 2021. It is now read-only.
HQLPARSER-43 Incorrect handling of string literals containing single quo... #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quotes Single quotes embedded in a string are actually represented by two single quotes. They are properly recognized by the lexer grammar but the output token should contain a single quote not two.
Contributor
Author
|
since I'm not an antlr expert... pls take my fix with a grain of salt :) |
Contributor
Author
|
@gunnarmorling Any chance to review it this week? Thanks! |
Member
|
Yes, I'll look into it this week. Thanks for the reminder :) 2014-06-30 13:07 GMT+02:00 Adrian Nistor notifications@github.com:
|
Member
|
Looks good to me; Going to merge it in a minute. |
Member
|
Merged; Also merged HQLPARSER-43_10x to 1.0.x. |
Contributor
Author
|
Thanks @gunnarmorling! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...tes
Single quotes embedded in a string are actually represented by two single quotes.
They are properly recognized by the lexer grammar but the output token should contain a single quote not two. (See spec doc Java Persistence 2.1, Final Release section 4.6.1)
Jira: https://hibernate.atlassian.net/browse/HQLPARSER-43
(this fix is needed for 1.0.x too, backport is in anistor:HQLPARSER-43_10x)