Skip to content

Commit 1cac1d5

Browse files
committed
Fix db/ci.node not being added to build scan tags
1 parent f81124c commit 1cac1d5

File tree

2 files changed

+27
-5
lines changed

2 files changed

+27
-5
lines changed

gradle/gradle-enterprise.gradle

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,10 @@ gradleEnterprise {
4747
uploadInBackground = !settings.ext.isCiEnvironment
4848

4949
tag "JDK ${JavaVersion.current().toString()}"
50-
String db = rootProject.hasProperty( 'db' ) ? rootProject.properties.db : 'h2'
51-
tag db
52-
value 'database', db
53-
if ( rootProject.hasProperty( 'ci.node' ) ) {
54-
tag rootProject.property('ci.node')
50+
tag extensions.db
51+
value 'database', extensions.db
52+
if ( extensions.hasProperty( 'ci.node' ) ) {
53+
tag extensions.property( 'ci.node' )
5554
}
5655
}
5756
}

local-build-plugins/src/main/java/org/hibernate/orm/env/EnvironmentSettingsPlugin.java

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
package org.hibernate.orm.env;
22

3+
import java.util.Map;
4+
import java.util.Objects;
5+
6+
import org.gradle.StartParameter;
37
import org.gradle.api.Plugin;
48
import org.gradle.api.initialization.Settings;
59

@@ -11,5 +15,24 @@ public class EnvironmentSettingsPlugin implements Plugin<Settings> {
1115
@Override
1216
public void apply(Settings settings) {
1317
settings.getExtensions().add( JpaVersion.EXT_KEY, JpaVersion.from( settings ) );
18+
settings.getExtensions().add( "db", Objects.requireNonNullElse( getP( settings, "db" ), "h2" ) );
19+
String ciNode = getP( settings, "ci.node" );
20+
if ( ciNode != null ) {
21+
settings.getExtensions().add( "ci.node", ciNode );
22+
}
23+
}
24+
25+
private static String getP(Settings settings, String key) {
26+
StartParameter startParameter = settings.getStartParameter();
27+
// the `-P` settings passed at command-line
28+
final Map<String, String> projectProperties = startParameter.getProjectProperties();
29+
final String projectProperty = projectProperties.get( key );
30+
if ( projectProperty != null && !projectProperty.isEmpty() ) {
31+
return projectProperty;
32+
}
33+
else {
34+
return null;
35+
}
1436
}
37+
1538
}

0 commit comments

Comments
 (0)