HHH-19449 allow use of static metamodel Type references to bind query parameters #10134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/main/java/org/hibernate/query/sqm/function/SelfRenderingSqmFunction.java
Fixed
Show fixed
Hide fixed
gavinking
force-pushed
the
HHH-19449
branch
2 times, most recently
from
cb48ca5 to
5fa4195
Compare
...nate-core/src/test/java/org/hibernate/orm/test/mapping/basic/TimeZoneColumnDurationTest.java
Fixed
Show fixed
Hide fixed
...nate-core/src/test/java/org/hibernate/orm/test/mapping/basic/TimeZoneColumnDurationTest.java
Fixed
Show fixed
Hide fixed
...nate-core/src/test/java/org/hibernate/orm/test/mapping/basic/TimeZoneColumnDurationTest.java
Fixed
Show fixed
Hide fixed
gavinking
force-pushed
the
HHH-19449
branch
2 times, most recently
from
abbb758 to
36261a9
Compare
seems we can just use getExpressible() which already calls getResolvedModel()
Remove BindableType.getBindableJavaType() which created all sorts of confusion with JPAs Bindable.getBindableJavaType(). Now can just use Type.getJavaType() for this.
|
|
||
| @Override | ||
| public ProcedureCall markAsFunctionCall(BindableType<?> typeReference) { | ||
| public ProcedureCall markAsFunctionCall(Type<?> typeReference) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
and to reduce possible confusion with JPA Bindable
gavinking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19449