Skip to content

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 26, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [1d4281f, 0fc5f2a, 7c94dc8]

› This message was automatically generated.

@gavinking gavinking marked this pull request as ready for review August 26, 2025 23:22
@gavinking gavinking force-pushed the more-sf-cleanups branch 2 times, most recently from 920b637 to d3b2172 Compare August 27, 2025 00:22
Property property) {
String value = accessor.value();
Class<?> type = accessor.strategy();
final String value = accessor.value();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
AttributeAccessor.value
should be avoided because it has been deprecated.
}

public static boolean isEmpty(Collection<?> collection) {
public static boolean isEmpty(@Nullable Collection<?> collection) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method CollectionHelper.isEmpty(..) could be confused with overloaded method
isEmpty
, since dispatch depends on static types.
}

public static boolean isNotEmpty(Collection<?> collection) {
public static boolean isNotEmpty(@Nullable Collection<?> collection) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method CollectionHelper.isNotEmpty(..) could be confused with overloaded method
isNotEmpty
, since dispatch depends on static types.
@gavinking gavinking merged commit 0a76cbe into hibernate:main Aug 27, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant