HHH-19757 fix registry APIs + simplification to CollectionJavaType #10888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
force-pushed
the
simplify-collectionjt
branch
from
236a9ca to
9a6f5f4
Compare
gavinking
force-pushed
the
simplify-collectionjt
branch
from
790ee6a to
f9b4304
Compare
gavinking
force-pushed
the
simplify-collectionjt
branch
from
f9b4304 to
feec8ea
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Function<TypeConfiguration, MutabilityPlan<?>> explicitMutabilityPlanAccess, | ||
| JdbcTypeIndicators stdIndicators, | ||
| Selectable selectable, | ||
| @SuppressWarnings("unused") JavaType<T> reflectedJtd, |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
|
||
| if ( parameters.containsKey( TYPE ) ) { | ||
| int jdbcTypeCode = Integer.parseInt( (String) parameters.get( TYPE ) ); | ||
| final int jdbcTypeCode = Integer.parseInt( (String) parameters.get( TYPE ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
gavinking
changed the title
gavinking
force-pushed
the
simplify-collectionjt
branch
from
d24e4f6 to
7ef0dbd
Compare
Many operations of TypeConfiguration, BasicTypeRegistry, JavaTypeRegistry were unsafe due to the use of an unbound type parameter in the return type. Note that this is in principle a breaking change to these SPIs. However, I've done it in a way that minimizes the impact on reasonable code.
gavinking
force-pushed
the
simplify-collectionjt
branch
from
7ef0dbd to
576f078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19757