Skip to content

[7.1] HHH-19784 Avoid using package-private field access with bytecode enhanced entity hierarchy #10982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

[7.1] HHH-19784 Avoid using package-private field access with bytecode enhanced entity hierarchy #10982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...te-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/EnhancerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,8 +823,23 @@ String getDescriptor() {
return fieldDescription.getDescriptor();
}

boolean isVisibleTo(TypeDescription typeDescription) {
return fieldDescription.isVisibleTo( typeDescription );
boolean isVisibleTo(TypeDescription type) {
final var declaringType = fieldDescription.getDeclaringType().asErasure();
if ( declaringType.isVisibleTo( type ) ) {
if ( fieldDescription.isPublic() || type.equals( declaringType ) ) {
return true;
}
else if ( fieldDescription.isProtected() ) {
return declaringType.isAssignableFrom( type );
}
else if ( fieldDescription.isPrivate() ) {
return type.isNestMateOf( declaringType );
}
// We explicitly consider package-private fields as not visible, as the classes
// might have the same package name but be loaded by different class loaders.
// (see https://hibernate.atlassian.net/browse/HHH-19784)
}
return false;
}

FieldDescription getFieldDescription() {
Expand Down