Skip to content

avoid unnecessarily holding onto Region in CacheRegionStatisticsImpl #11004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

avoid unnecessarily holding onto Region in CacheRegionStatisticsImpl #11004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions hibernate-core/src/main/java/org/hibernate/stat/internal/CacheRegionStatisticsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.io.Serializable;
import java.util.concurrent.atomic.LongAdder;

import org.checkerframework.checker.nullness.qual.Nullable;
import org.hibernate.cache.spi.ExtendedStatisticsSupport;
import org.hibernate.cache.spi.Region;
import org.hibernate.stat.CacheRegionStatistics;
Expand All @@ -17,20 +18,25 @@
* @author Alex Snaps
*/
public class CacheRegionStatisticsImpl implements CacheRegionStatistics, Serializable {
private final transient Region region;
private final String regionName;
private final transient @Nullable ExtendedStatisticsSupport extendedStatisticsSupport;

private final LongAdder hitCount = new LongAdder();
private final LongAdder missCount = new LongAdder();
private final LongAdder putCount = new LongAdder();
private final LongAdder removeCount = new LongAdder();

CacheRegionStatisticsImpl(Region region) {
this.region = region;
regionName = region.getName();
extendedStatisticsSupport =
region instanceof ExtendedStatisticsSupport extended
? extended
: null;
}

@Override
public String getRegionName() {
return region.getName();
return regionName;
}

@Override
Expand All @@ -55,23 +61,23 @@ public long getRemoveCount() {

@Override
public long getElementCountInMemory() {
return region instanceof ExtendedStatisticsSupport extended
? extended.getElementCountInMemory()
: NO_EXTENDED_STAT_SUPPORT_RETURN;
return extendedStatisticsSupport == null
? NO_EXTENDED_STAT_SUPPORT_RETURN
: extendedStatisticsSupport.getElementCountInMemory();
}

@Override
public long getElementCountOnDisk() {
return region instanceof ExtendedStatisticsSupport extended
? extended.getElementCountOnDisk()
: NO_EXTENDED_STAT_SUPPORT_RETURN;
return extendedStatisticsSupport == null
? NO_EXTENDED_STAT_SUPPORT_RETURN
: extendedStatisticsSupport.getElementCountOnDisk();
}

@Override
public long getSizeInMemory() {
return region instanceof ExtendedStatisticsSupport extended
? extended.getSizeInMemory()
: NO_EXTENDED_STAT_SUPPORT_RETURN;
return extendedStatisticsSupport == null
? NO_EXTENDED_STAT_SUPPORT_RETURN
: extendedStatisticsSupport.getSizeInMemory();
}

void incrementHitCount() {
Expand All @@ -93,15 +99,18 @@ public void incrementRemoveCount() {

@Override
public String toString() {
return "CacheRegionStatistics"
+ "[region=" + region.getName()
+ ",hitCount=" + hitCount
+ ",missCount=" + missCount
+ ",putCount=" + putCount
+ ",removeCount=" + removeCount
+ ",elementCountInMemory=" + getElementCountInMemory()
+ ",elementCountOnDisk=" + getElementCountOnDisk()
+ ",sizeInMemory=" + getSizeInMemory()
+ ']';
final var string =
new StringBuilder("CacheRegionStatistics")
.append( "[region=" ).append( regionName )
.append( ",hitCount=" ).append( hitCount )
.append( ",missCount=" ).append( missCount )
.append( ",putCount=" ).append( putCount )
.append( ",removeCount=" ).append( removeCount );
if ( extendedStatisticsSupport != null ) {
string.append( ",elementCountInMemory=" ).append( getElementCountInMemory() )
.append( ",elementCountOnDisk=" ).append( getElementCountOnDisk() )
.append( ",sizeInMemory=" ).append( getSizeInMemory() );
}
return string.append( ']' ).toString();
}
}