-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19849 Add an SPI that allows attaching session-scoped "extensions" to the session/statelesssession implementors #11093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marko-bekhta
wants to merge
1
commit into
hibernate:main
Choose a base branch
from
marko-bekhta:feat/HHH-19849-Add-an-SPI-that-allows-attaching-session-scoped-extensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
...rc/main/java/org/hibernate/engine/extension/internal/ExtensionIntegrationServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.engine.extension.internal; | ||
|
|
||
| import org.hibernate.boot.registry.classloading.spi.ClassLoaderService; | ||
| import org.hibernate.engine.extension.spi.ExtensionIntegration; | ||
| import org.hibernate.engine.extension.spi.ExtensionIntegrationService; | ||
| import org.jboss.logging.Logger; | ||
|
|
||
| import java.util.LinkedHashSet; | ||
| import java.util.Set; | ||
|
|
||
| public class ExtensionIntegrationServiceImpl implements ExtensionIntegrationService { | ||
|
|
||
| private static final Logger LOG = Logger.getLogger( ExtensionIntegrationServiceImpl.class ); | ||
|
|
||
| private final LinkedHashSet<ExtensionIntegration<?>> integrators = new LinkedHashSet<>(); | ||
|
|
||
| private ExtensionIntegrationServiceImpl() { | ||
| } | ||
|
|
||
| public static ExtensionIntegrationServiceImpl create(Set<ExtensionIntegration<?>> integrations, ClassLoaderService classLoaderService) { | ||
| ExtensionIntegrationServiceImpl instance = new ExtensionIntegrationServiceImpl(); | ||
|
|
||
| // register provided integrators | ||
| for ( ExtensionIntegration<?> integration : integrations ) { | ||
| instance.addExtensionIntegration( integration ); | ||
| } | ||
| for ( ExtensionIntegration<?> integration : classLoaderService.loadJavaServices( | ||
| ExtensionIntegration.class ) ) { | ||
| instance.addExtensionIntegration( integration ); | ||
| } | ||
|
|
||
| return instance; | ||
| } | ||
|
|
||
| private void addExtensionIntegration(ExtensionIntegration<?> integration) { | ||
| if ( LOG.isDebugEnabled() ) { | ||
| LOG.debugf( "Adding extension integration for [%s]", integration.getExtensionType().getName() ); | ||
| } | ||
| integrators.add( integration ); | ||
| } | ||
|
|
||
| @Override | ||
| public Iterable<ExtensionIntegration<?>> extensionIntegrations() { | ||
| return integrators; | ||
| } | ||
| } |
12 changes: 12 additions & 0 deletions
12
hibernate-core/src/main/java/org/hibernate/engine/extension/spi/Extension.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.engine.extension.spi; | ||
|
|
||
| import org.hibernate.Incubating; | ||
|
|
||
| /// A marker interface for Session extensions. | ||
| @Incubating | ||
| public interface Extension { | ||
| } |
14 changes: 14 additions & 0 deletions
14
hibernate-core/src/main/java/org/hibernate/engine/extension/spi/ExtensionIntegration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.engine.extension.spi; | ||
|
|
||
| import org.hibernate.Incubating; | ||
|
|
||
| @Incubating | ||
| public interface ExtensionIntegration<E extends Extension> { | ||
| Class<E> getExtensionType(); | ||
|
|
||
| E createExtension(ExtensionIntegrationContext context); | ||
| } | ||
14 changes: 14 additions & 0 deletions
14
...te-core/src/main/java/org/hibernate/engine/extension/spi/ExtensionIntegrationContext.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.engine.extension.spi; | ||
|
|
||
| import org.hibernate.Incubating; | ||
| import org.hibernate.engine.spi.SharedSessionContractImplementor; | ||
|
|
||
| @Incubating | ||
| public interface ExtensionIntegrationContext { | ||
|
|
||
| SharedSessionContractImplementor getSession(); | ||
| } |
18 changes: 18 additions & 0 deletions
18
...te-core/src/main/java/org/hibernate/engine/extension/spi/ExtensionIntegrationService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.engine.extension.spi; | ||
|
|
||
| import org.hibernate.Incubating; | ||
| import org.hibernate.service.Service; | ||
|
|
||
| @Incubating | ||
| public interface ExtensionIntegrationService extends Service { | ||
| /** | ||
| * Retrieve all extensions. | ||
| * | ||
| * @return All extensions. | ||
| */ | ||
| Iterable<ExtensionIntegration<?>> extensionIntegrations(); | ||
| } |
29 changes: 29 additions & 0 deletions
29
...rc/main/java/org/hibernate/engine/extension/spi/ExtensionIntegrationServiceInitiator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.engine.extension.spi; | ||
|
|
||
| import org.hibernate.Incubating; | ||
| import org.hibernate.engine.extension.internal.ExtensionIntegrationServiceImpl; | ||
| import org.hibernate.service.spi.SessionFactoryServiceInitiator; | ||
| import org.hibernate.service.spi.SessionFactoryServiceInitiatorContext; | ||
|
|
||
| import java.util.Set; | ||
|
|
||
| @Incubating | ||
| public class ExtensionIntegrationServiceInitiator | ||
| implements SessionFactoryServiceInitiator<ExtensionIntegrationService> { | ||
|
|
||
| public static final ExtensionIntegrationServiceInitiator INSTANCE = new ExtensionIntegrationServiceInitiator(); | ||
|
|
||
| @Override | ||
| public ExtensionIntegrationService initiateService(SessionFactoryServiceInitiatorContext context) { | ||
| return ExtensionIntegrationServiceImpl.create( Set.of(), context.getSessionFactory().getClassLoaderService() ); | ||
| } | ||
|
|
||
| @Override | ||
| public Class<ExtensionIntegrationService> getServiceInitiated() { | ||
| return ExtensionIntegrationService.class; | ||
| } | ||
| } |
7 changes: 7 additions & 0 deletions
7
hibernate-core/src/main/java/org/hibernate/engine/extension/spi/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| /** | ||
| * This package contains an SPI for Session extensions. | ||
| */ | ||
| @Incubating | ||
| package org.hibernate.engine.extension.spi; | ||
|
|
||
| import org.hibernate.Incubating; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.