Add JdbcSelectWithActionsBuilder and other changes to adapt HibernateReactive to the changes introduced by HHH-19513 #11139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Map<Object, EntityDetails> entityDetailsMap, | ||
| EntityMappingType entityMappingType, | ||
| EffectiveEntityGraph effectiveEntityGraph, | ||
| List<EntityKey> entityKeys, |
Check notice
Code scanning / CodeQL
Useless parameter Note
dreab8
changed the title
sebersole
reviewed
Oct 22, 2025
hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcSelectWithActionsBuilder.java
Outdated
Show resolved
Hide resolved
sebersole
reviewed
Oct 22, 2025
hibernate-core/src/main/java/org/hibernate/sql/exec/internal/JdbcSelectWithActions.java
Outdated
Show resolved
Hide resolved
sebersole
reviewed
Oct 22, 2025
hibernate-core/src/main/java/org/hibernate/engine/spi/SessionFactoryImplementor.java
Show resolved
Hide resolved
|
I suggested a few minor changes. Other than that, lgtm |
… Reactive to the cvhanges intorduced by HHH-19513
dreab8
force-pushed
the
reactivePostActions
branch
from
533f13d to
f93de90
Compare
|
Thanks @sebersole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.