Skip to content

Conversation

@beikov
Copy link
Member

@beikov beikov commented Oct 22, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19888

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 22, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [68f300e]

› This message was automatically generated.

@Override
public String castPattern(CastType from, CastType to) {
String result;
switch ( to ) {

Check warning

Code scanning / CodeQL

Missing enum case in switch Warning

Switch statement does not have a case for
BOOLEAN
,
DOUBLE
,
FIXED
, or 8 more.
}
break;
case STRING:
switch ( from ) {

Check warning

Code scanning / CodeQL

Missing enum case in switch Warning

Switch statement does not have a case for
CLOB
,
DOUBLE
,
FIXED
, or 8 more.
@beikov beikov force-pushed the carlblan-timesten_dialect_updates branch from 16d3891 to b29d486 Compare October 22, 2025 10:53
@carlblan
Copy link

Hi @beikov I just tested your new changes to address bug in the handling of static offsets

I ran my tests using a hibernate-core local snapshot build out from this PR. And can confirm that the issue that I saw when using:
renderFetchPlusOffsetExpressionAsSingleParameter( ) in TimesTenSqlAstTranslator.java

Is now resolved.

Thank you for taking the time to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants