Skip to content

HHH-19749/HHH-18860 fix to precision of double/float mapped to DECIMAL/NUMERIC #11274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
+12 −27
Merged

HHH-19749/HHH-18860 fix to precision of double/float mapped to DECIMAL/NUMERIC #11274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions hibernate-core/src/main/java/org/hibernate/type/descriptor/java/DoubleJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
import org.hibernate.type.descriptor.jdbc.JdbcType;
import org.hibernate.type.descriptor.jdbc.JdbcTypeIndicators;

import static java.lang.Math.ceil;
import static java.lang.Math.log;

/**
* Descriptor for {@link Double} handling.
*
Expand All @@ -26,8 +23,6 @@
public class DoubleJavaType extends AbstractClassJavaType<Double> implements
PrimitiveJavaType<Double> {
public static final DoubleJavaType INSTANCE = new DoubleJavaType();
//needed for converting precision from binary to decimal digits
private static final double LOG_BASE10OF2 = log(2)/log(10);

public DoubleJavaType() {
super( Double.class );
Expand Down Expand Up @@ -156,17 +151,14 @@ public long getDefaultSqlLength(Dialect dialect, JdbcType jdbcType) {

@Override
public int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) {
if ( jdbcType.isFloat() ) {
//this is the number of *binary* digits
//in a double-precision FP number
return dialect.getDoublePrecision();
}
else {
return Math.min( dialect.getDefaultDecimalPrecision(), (int) ceil( dialect.getDoublePrecision() * LOG_BASE10OF2 ) );
}
return jdbcType.isFloat()
// this is usually the number of *binary* digits
// in a double-precision FP number
? dialect.getDoublePrecision()
// this is the number of decimal digits in a Java double
: 17;
}


@Override
public <X> Double coerce(X value, CoercionContext coercionContext) {
if ( value == null ) {
Expand Down
19 changes: 6 additions & 13 deletions hibernate-core/src/main/java/org/hibernate/type/descriptor/java/FloatJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,13 @@
import org.hibernate.type.descriptor.jdbc.JdbcType;
import org.hibernate.type.descriptor.jdbc.JdbcTypeIndicators;

import static java.lang.Math.ceil;
import static java.lang.Math.log;

/**
* Descriptor for {@link Float} handling.
*
* @author Steve Ebersole
*/
public class FloatJavaType extends AbstractClassJavaType<Float> implements PrimitiveJavaType<Float> {
public static final FloatJavaType INSTANCE = new FloatJavaType();
//needed for converting precision from binary to decimal digits
private static final double LOG_BASE10OF2 = log(2)/log(10);

public FloatJavaType() {
super( Float.class );
Expand Down Expand Up @@ -154,14 +149,12 @@ public long getDefaultSqlLength(Dialect dialect, JdbcType jdbcType) {

@Override
public int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) {
if ( jdbcType.isFloat() ) {
//this is the number of *binary* digits
//in a single-precision FP number
return dialect.getFloatPrecision();
}
else {
return Math.min( dialect.getDefaultDecimalPrecision(), (int) ceil( dialect.getFloatPrecision() * LOG_BASE10OF2 ) );
}
return jdbcType.isFloat()
// this is usually the number of *binary* digits
// in a single-precision FP number
? dialect.getFloatPrecision()
// this is the number of decimal digits in a Java float
: 8;
}

@Override
Expand Down
Loading