-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Optimize auto flush #11287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize auto flush #11287
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
hibernate-core/src/main/java/org/hibernate/event/internal/DefaultAutoFlushEventListener.java
Outdated
Show resolved
Hide resolved
beikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, but the SPI changes might be a problem for 7.2.
I checked Search and Reactive and there is no impact on either. Would have been better if we had marked those methods |
hibernate-core/src/main/java/org/hibernate/query/internal/QueryParameterBindingsImpl.java
Outdated
Show resolved
Hide resolved
abc63c2 to
81b785d
Compare
Co-authored-by: Marco Belladelli <marcobladel@gmail.com>
81b785d to
9d189c1
Compare
The impact I was thinking of was on indexing, not necessarily on SPIs. Well, now it's been merged I suppose @marko-bekhta can easily tell us if it breaks tests. |
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.