Skip to content

Conversation

@gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 19, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [f27b93e, 9deeffc, aad3c33, 76ebaee, 119cd8b, 77a5ed5, 9d189c1]

› This message was automatically generated.

@gavinking gavinking marked this pull request as ready for review November 19, 2025 12:38
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but the SPI changes might be a problem for 7.2.

@gavinking
Copy link
Member Author

the SPI changes might be a problem

I checked Search and Reactive and there is no impact on either.

Would have been better if we had marked those methods @Incubating when we added them.

Co-authored-by: Marco Belladelli <marcobladel@gmail.com>
@gavinking gavinking merged commit 3dada25 into hibernate:main Nov 19, 2025
40 of 42 checks passed
@yrodiere
Copy link
Member

I checked Search and Reactive and there is no impact on either.

The impact I was thinking of was on indexing, not necessarily on SPIs.

Well, now it's been merged I suppose @marko-bekhta can easily tell us if it breaks tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants