Skip to content

Backport HHH-13266 to branch 5.3 - LocalDateTime values are wrong around 1900 (caused by JDK-8061577) #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 19, 2019
Merged

Backport HHH-13266 to branch 5.3 - LocalDateTime values are wrong around 1900 (caused by JDK-8061577) #2813

merged 22 commits into from
Apr 19, 2019

Conversation

yrodiere
Copy link
Member

https://hibernate.atlassian.net//browse/HHH-13266

@gbadner I think we should backport this to 5.3?

yrodiere and others added 18 commits March 14, 2019 08:56
@yrodiere
HHH-13266 Test LocalDateTime serialization, in particular around 1900…
4fcebf1 
…-01-01T00:00:00
@yrodiere
HHH-13266 Fix LocalDateTime serialization by using the proper convers…
e58f566 
…ion methods between LocalDateTime and Timestamp
@gbadner @yrodiere
HHH-13266 Change test to use raw JDBC for executing native query
6f81351
@yrodiere
HHH-13266 Test LocalDate serialization, in particular around 1900-01-01
e77b2b2
@yrodiere
HHH-13266 Test OffsetDateTime serialization, in particular around 190…
bd1609d 
…0-01-01
@yrodiere
HHH-13266 Fix OffsetDateTime serialization by using the proper conver…
0c648a5 
…sion methods between OffsetDateTime and Timestamp
@yrodiere
HHH-13266 Test ZonedDateTime serialization, in particular around 1900…
7b3d4a4 
…-01-01
@yrodiere
HHH-13266 Fix ZonedDateTime serialization by using the proper convers…
ff8baee 
…ion methods between ZonedDateTime and Timestamp
@yrodiere
HHH-13266 Test Instant serialization, in particular around 1900-01-01
6b850cf
@yrodiere
HHH-13266 Fix Instant serialization by using the proper conversion me…
6882ce6 
…thods between Instant and Timestamp
@yrodiere
HHH-13266 Add an abstract class for all java.time tests for this ticket
e17b597 
So that we can hopefully factorize the upcoming additions.
@yrodiere
HHH-13266 Test reading of values written without Hibernate ORM in Abs…
314bfb5 
…tractJavaTimeTypeTest
@yrodiere
HHH-13266 Allow to override the SQL type mappings in AbstractJavaTime…
e93794e 
…TypeTest
@yrodiere
HHH-13266 Test LocalDate serialization when dates are remapped as Tim…
7060650 
…estamp, in particular around 1900-01-01
@yrodiere
HHH-13266 Fix LocalDate serialization by using the proper conversion …
704861f 
…methods between LocalDate and Timestamp
@yrodiere
HHH-13266 Test LocalTime serialization
0157a95
@yrodiere
HHH-13266 Test OffsetTime serialization
bdaad9b
@yrodiere
HHH-13266 Test serialization of java.time types when hibernate.jdbc.t…
0ec5653 
…ime_zone is set
@yrodiere yrodiere mentioned this pull request Mar 14, 2019
Merged
yrodiere added 2 commits March 14, 2019 16:56
@yrodiere
HHH-13266 Mark most databases as not supporting nanosecond-precision …
037e7c3 
…storage for timestamps

At least PostgreSQL, Oracle, MySQL and HANA don't support it.
@yrodiere
HHH-13266 Skip tests that involve timestamps before epoch with MySQL/…
011ce45 
…Mariadb
@yrodiere yrodiere changed the title Backport HHH-13266 to branch 5.3 - LocalDateTime values are wrong around 1900 (caused by JDK-8061577) [ON HOLD] Backport HHH-13266 to branch 5.3 - LocalDateTime values are wrong around 1900 (caused by JDK-8061577) Mar 14, 2019
@yrodiere
Copy link
Member Author

Please hold; I had to push a few test fixes for non-H2 databases in #2815. I added the commits to this PR, but let's not backport until #2815 is merged...

@gbadner
Copy link
Contributor

gbadner commented Mar 14, 2019

@yrodiere, thanks for creating this PR!

@yrodiere yrodiere changed the title [ON HOLD] Backport HHH-13266 to branch 5.3 - LocalDateTime values are wrong around 1900 (caused by JDK-8061577) Backport HHH-13266 to branch 5.3 - LocalDateTime values are wrong around 1900 (caused by JDK-8061577) Mar 19, 2019
@yrodiere
Copy link
Member Author

#2815 was merged into branch master and it fixed the failing mariaDB, Oracle and HANA jobs.

We can safely merge this in 5.3 if that's what you want, @gbadner .

@gbadner
HHH-13266 : Skip OffsetTimeTest#nativeWriteThenRead and #writeThenRea…
fcf5609 
…d in some cases due to HHH-13357

            when Time is remapped as Timestamp and default JVM is not GMT
@gbadner
Copy link
Contributor

gbadner commented Apr 19, 2019

I added a commit to skip the failing tests.

@gbadner gbadner merged commit 664d435 into hibernate:5.3 Apr 19, 2019
@yrodiere yrodiere deleted the HHH-13266-5.3 branch June 26, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

5.3 Requires Gail

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yrodiere @gbadner