HHH-14137 Empty String check performance improvements #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
awesome. I wanna repeat the article link in the ticket here: https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416
gsmet
previously requested changes
Aug 4, 2020
hibernate-core/src/main/java/org/hibernate/cfg/Ejb3JoinColumn.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/engine/internal/JoinSequence.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/engine/internal/JoinSequence.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/hql/internal/ast/util/SyntheticAndFactory.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/loader/OuterJoinableAssociation.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/loader/OuterJoinableAssociation.java
Outdated
Show resolved
Hide resolved
...n/java/org/hibernate/envers/configuration/internal/metadata/CollectionMetadataGenerator.java
Outdated
Show resolved
Hide resolved
Sanne
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Good catch!
Although I agree with @gsmet , this is unlikely to make any noticeable difference, but some of this code is very hot so why not.
The (minor) drawbacks I see:
- it's less readable
- if this pattern becomes "the standard way" one needs to be careful in not forgetting the null check
- we're working primarily on ORM6, we should generally not make such changes on master: please prefer the
wip/6.0branch for such changes, in case you have more changes of this type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-14137