HHH-2558: Fix batching inserts for multi-table entities #3682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The referenced issue was closed, apparently fixed. And the code has changed very significantly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix of https://hibernate.atlassian.net/browse/HHH-2558 caused https://hibernate.atlassian.net/browse/HHH-12470 and was reverted by adding back jdbcCoordinator.executeBatch() in StatementPreparerImpl.prepareStatement(String sql, final boolean isCallable)
The problem with deletes in HHH-12470 was caused by batch deletes not being flushed before non batch delete. That's why we still need executeBatch() in prepareStatement(String sql, final boolean isCallable) that is used by non batch delete
The idea behind this fix is that we use prepareStatement(String sql) (which doesn't trigger executeBatch()) for AbstractBatchImpl.buildBatchStatement with non callable sql