HHH-15848 Session.isDirty() and more #9379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is definitely not perfect yet, but it's definitely a much better foundation than the ancient implementation which was bad and side-effecty in all sorts of ways
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| && !collection.isDirty() //optimization | ||
| && loadedPersister != null | ||
| && loadedPersister.isMutable() //optimization | ||
| && ( collection.isDirectlyAccessible() || loadedPersister.getElementType().isMutable() ) //optimization |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| && loadedPersister != null | ||
| && loadedPersister.isMutable() //optimization | ||
| // && !loadedPersister.isInverse() // even if it's inverse, could still result in a cache update | ||
| && ( collection.isDirectlyAccessible() || loadedPersister.getElementType().isMutable() ) //optimization |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| } | ||
| else { | ||
| assert uniqueKeyPropertyName != null; | ||
| final Type keyType = persister.getPropertyType( uniqueKeyPropertyName ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| // We now have the value of the property-ref we reference. However, | ||
| // we need to dig a little deeper, as that property might also be | ||
| // an entity type, in which case we need to resolve its identifier | ||
| final Type type = entityPersister.getPropertyType( uniqueKeyPropertyName ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Member
Author
|
superseded by #9476. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-15848