try syncing duration handling in Cockroach with Postgres #9411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just fyi, if you want to test something against CockroachDB you have to add the |
gavinking
force-pushed
the
cockroach-durations
branch
from
209cde3 to
720d7ce
Compare
gavinking
force-pushed
the
cockroach-durations
branch
2 times, most recently
from
4e4e69b to
5f339bc
Compare
gavinking
force-pushed
the
cockroach-durations
branch
from
5f339bc to
2860351
Compare
Member
Author
|
OK, so in the end I have managed to satisfy myself that there really was a good reason we do this different in Cockroach. Good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an experiment because I can't test this locally.
Redo of #8316, essentially.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.