HHH-18933 the ordering of the class declaration in persistence.xml seems to affect the metamodel #9548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added additional test using classes from article Hibernate ORM 6.6 - Embeddable Inheritance |
mbellade
reviewed
Jan 28, 2025
hibernate-core/src/test/java/org/hibernate/orm/test/org/hierarchyorder/HierarchyOrderTest.java
Outdated
Show resolved
Hide resolved
mbellade
reviewed
Jan 28, 2025
...re/src/test/java/org/hibernate/orm/test/embeddableinheritance/EmbeddableInheritanceTest.java
Outdated
Show resolved
Hide resolved
...re/src/test/java/org/hibernate/orm/test/embeddableinheritance/EmbeddableInheritanceTest.java
Outdated
Show resolved
Hide resolved
...re/src/test/java/org/hibernate/orm/test/embeddableinheritance/EmbeddableInheritanceTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/org/hierarchyorder/HierarchyOrderTest.java
Outdated
Show resolved
Hide resolved
Member
|
Thanks @cigaly, looks great now! One last thing, could you please open a PR with just the tests to confirm this is already fixed in |
Contributor
Author
|
OK, I'll do it |
Member
|
Test compilation is failing, please fix that. Also would be great if you could apply Hibernate's code style to the test classes as well as the main code. |
Contributor
Author
|
Sorry, I've forgot that 6.6 should be compiled with JDK 11, and 7.0 with JDK 17. I'll fix that now |
…d in equivalent way as in main (7.0) branch
Contributor
Author
|
There are still thousands of checkstyle violation, but none in those two test classes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-18933
Method
org.hibernate.boot.model.source.internal.annotations.AnnotationMetadataSourceProcessorImpl#orderAndFillHierarchyhas not been properly ordering classes.Fixing problem by adding method
org.hibernate.boot.model.source.internal.annotations.AnnotationMetadataSourceProcessorImpl#orderHierarchyand ordering classes before returning fromorderAndFillHierarchy. Added method is equivalent to one that is (properly) ordering classes in main branch.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.