HHH-18723 Support @SQLRestriction in class marked as @MappedSuperclass #9744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
reviewed
Feb 13, 2025
hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java
Outdated
Show resolved
Hide resolved
beikov
reviewed
Feb 13, 2025
hibernate-core/src/test/java/org/hibernate/orm/test/where/annotations/MappedSuperclassTest.java
Outdated
Show resolved
Hide resolved
beikov
approved these changes
Feb 13, 2025
gavinking
requested changes
Feb 13, 2025
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
To fix the test failures you'll need to make a change in EntityBinder around line 1354, in order to distinguish the case of a @MappedSuperclass.
Contributor
Author
|
I fixed calculation. Now it only inherit annotation from |
gavinking
reviewed
Feb 14, 2025
...e-core/src/test/java/org/hibernate/orm/test/customsql/CustomSqlRestrictionOverridesTest.java
Show resolved
Hide resolved
Contributor
Author
|
Just to be clear. I finished all my changes and expecting input from your side. |
a-e-tsvetkov
force-pushed
the
feature/HHH-18723-v2
branch
from
64bf28b to
76d4c85
Compare
a-e-tsvetkov
force-pushed
the
feature/HHH-18723-v2
branch
from
76d4c85 to
e4f5edb
Compare
a-e-tsvetkov
force-pushed
the
feature/HHH-18723-v2
branch
from
e4f5edb to
955ae4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have several entities with common super class SoftDeleteSupport marked with @MappedSuperclass annotation. It have boolean rmv; field.
Currently I have to put @SQLRestriction in each entity.
I propose to support @SQLRestriction on classes marked with @MappedSuperclass t reduce code duplication.
This PR is intends to fix HHH-18723
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.