Add log message about Vert.x at start up #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not detected: ``` [INFO] HR000002: Vert.x not detected, creating a new instance ``` if detected: ``` [DEBUG] Vert.x instance detected ```
DavideD
changed the title
gavinking
approved these changes
Jan 19, 2022
Member
|
Should we have codes for the debug messages? |
Member
Author
|
As far as I know, anything from debug and under doesn't need to have a code. |
Member
Author
|
I'm happy to move it to INFO level so that we always print something |
Member
|
No no, just wanted to make sure we were being consistent. Don't recall what we do with other debug-level log messages. |
Member
Author
|
Merged #1142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134
[INFO] HR000002: Vert.x not detected, creating a new instance[DEBUG] Vert.x instance detected