[4.2] Update license headers #2860
Merged
+1,427
−2,030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It reminds us which test case is using it, and it also handy to use it with Spotless: Spotless ignore pacakge-info.java files, but if we add javadoc we can create a separate rule for applying the license header.
Hibernate Reactive is using a license header for the java file that's a little different from the other projects
It seems we don't need them anymor
DavideD
added
build
Member
|
You'll probably want to have something like
once this one is in 🙂 |
Member
Author
|
OK, thanks, I will add the blame ignore file |
This was referenced Dec 2, 2025
And `module-info.java` Spotless ingores package-info.java files (see diffplug/spotless#532), but we can create a rule that applies it if the file contains a javadoc. Note that if the package-info.java doesn't have a javadoc, it will cause an exception at compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2855
Align the headers to the other projects.
I also added a rule for package-info.java files (they were skipped because of this issue in Spotless):
it will add the header before the javadoc and fail the compilation if a javadoc is missing. I think it's an acceptable trade off if we want to be consistent among projects.