HSEARCH-1480 newArrayList helper should mandate a size hint

Author: Sanne

engine/src/main/java/org/hibernate/search/query/dsl/impl/FacetBuildingContext.java

@@ -24,6 +24,7 @@
 
 package org.hibernate.search.query.dsl.impl;
 
+import java.util.Arrays;
 import java.util.Date;
 import java.util.List;
 
@@ -43,16 +44,14 @@ class FacetBuildingContext<T> {
 	/**
 	 * The list of types which are supported for range faceting
 	 */
-	private static final List<Class<?>> allowedRangeTypes = newArrayList( 6 );
-
-	static {
-		allowedRangeTypes.add( String.class );
-		allowedRangeTypes.add( Integer.class );
-		allowedRangeTypes.add( Long.class );
-		allowedRangeTypes.add( Double.class );
-		allowedRangeTypes.add( Float.class );
-		allowedRangeTypes.add( Date.class );
-	}
+	private static final List<Class<?>> allowedRangeTypes = Arrays.<Class<?>>asList(
+			String.class,
+			Integer.class,
+			Long.class,
+			Double.class,
+			Float.class,
+			Date.class
+		);
 
 	private final SearchFactoryImplementor factory;
 	private final Class<?> entityType;

engine/src/main/java/org/hibernate/search/util/impl/CollectionHelper.java

@@ -25,7 +25,6 @@
 package org.hibernate.search.util.impl;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -68,7 +67,9 @@ public static <T> ArrayList<T> newArrayList(final int size) {
 	}
 
 	public static <T> Set<T> asSet(T... ts) {
-		return new HashSet<T>( Arrays.asList( ts ) );
+		HashSet<T> set = new HashSet<T>( ts.length );
+		Collections.addAll( set, ts );
+		return set;
 	}
 
 	public static <T> List<T> toImmutableList(final Collection<T> c) {