HSEARCH-3564 Use lambda or member reference #2062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstenartur
changed the title
yrodiere
requested changes
Aug 23, 2019
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Looks like there are style issues, see https://ci.hibernate.org/job/hibernate-search/job/PR-2062/1/display/redirect :
[ERROR] /mnt/jenkins-workdir/workspace/hibernate-search_PR-2062/backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/analysis/model/dsl/impl/ElasticsearchAnalysisConfigurationContextImpl.java:16:8: Unused import - org.hibernate.search.backend.elasticsearch.analysis.model.dsl.ElasticsearchNormalizerOptionalComponentsStep. [UnusedImports]
I'd recommend running the build before you submit a PR, at least just the compiling/static checks, without the tests:
mvn clean install -DskipTests
db063c2 to
8a972c7
Compare
Converts anonymous inner classes to lambda expressions or member references
carstenartur
force-pushed
the
uselambda
branch
from
8a972c7 to
5256da2
Compare
yrodiere
approved these changes
Sep 13, 2019
Member
|
Fixed indentation, added the ticket number to the commit message and merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-3564
Converts anonymous inner classes to lambda expressions or member references.