HSEARCH-3564 Protected member in final class #2063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
requested changes
Aug 23, 2019
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Looks like there are issues, see https://ci.hibernate.org/blue/organizations/jenkins/hibernate-search/detail/PR-2063/1/pipeline :
[ERROR] /mnt/jenkins-workdir/workspace/hibernate-search_PR-2063/backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/predicate/impl/LuceneGeoPointFieldPredicateBuilderFactory.java:[86,46] getConverter() in org.hibernate.search.backend.lucene.types.predicate.impl.LuceneGeoPointFieldPredicateBuilderFactory cannot override getConverter() in org.hibernate.search.backend.lucene.types.predicate.impl.AbstractLuceneFieldPredicateBuilderFactory
I'd recommend running the build before you submit a PR, at least just the compiling/static checks, without the tests:
mvn clean install -DskipTests
any instances of members being declared protected in classes that are declared final. Such members may be declared private or package-visible instead.
carstenartur
force-pushed
the
protectedmemberinfinalclass
branch
from
4df7535 to
2dc8a36
Compare
Member
|
I will revert the change about |
yrodiere
approved these changes
Sep 13, 2019
Member
|
Removed the bit about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any instances of members being declared protected in classes that are
declared final. Such members may be declared private or package-visible
instead.