HSEARCH-3615 Document the query DSL in details #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
added
the
Waiting for other pull request
yrodiere
force-pushed
the
HSEARCH-3615
branch
from
16b15ba to
b1f0987
Compare
yrodiere
added
Ready for review
and removed
Waiting for other pull request
fax4ever
previously requested changes
Sep 10, 2019
Contributor
fax4ever
left a comment
fax4ever
left a comment
There was a problem hiding this comment.
Nice work!
I have few comments here.
Calling fetch() or fetchHits() without a limit is a bad idea unless you know what you're doing, so we'd better not show that everywhere.
yrodiere
force-pushed
the
HSEARCH-3615
branch
from
b1f0987 to
2ad1cbe
Compare
Member
Author
|
Thanks! I addressed all of your comments and force-pushed. Waiting for CI, then I'll merge. |
Member
Author
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSEARCH-3615: Document the query DSL in details
Based on #2069 , which should be merged first.=> Done