HSEARCH-3606 Revisit the names of "SearchWriter" and "SearchSessionWritePlan" #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
added
the
Waiting for other pull request
fax4ever
approved these changes
Sep 16, 2019
Contributor
fax4ever
left a comment
fax4ever
left a comment
There was a problem hiding this comment.
Nice job!
I've just a doubt. Actually it's a while that I'm asking to myself if we need to keep both prepare and process terms, not having a single term such for execute.
Anyway +1 to merge these changes from me.
...main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchSessionSession.java
Outdated
Show resolved
Hide resolved
...jo/src/main/java/org/hibernate/search/mapper/pojo/work/impl/PojoIndexedTypeIndexingPlan.java
Show resolved
Hide resolved
SearchWorkspace = SearchScope + tenantId
…ateOrmSearchSession
For consistency with the ORM SearchIndexingPlan, and also because this class will indeed always be about indexing and nothing else.
Both consistency with the SearchIndexingPlan and internal consistency.
…dexingPlan For consistency with the ORM SearchIndexingPlan, and also because this class will indeed always be about indexing and nothing else.
… the JavaBean mapper
For consistency with APIs.
For consistency with PojoIndexingPlan and APIs, and also because these classes will only ever be about indexing.
…ocumentWorkExecutor to IndexIndexer Because these classes will only ever be about indexing or deleting documents.
…ndexWorkExecutor to IndexWorkspace For consistency with the new SearchWorkspace API.
yrodiere
force-pushed
the
HSEARCH-3606
branch
from
6f24069 to
32a1cda
Compare
yrodiere
added
Ready for review
and removed
Waiting for other pull request
Member
Author
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-3606
Based on #2084 , which should be merged first.=> DoneI renamed
SearchSessionWritePlantoSearchIndexingPlan. It's both simpler, and more to the point: this is about indexing.Also, it doesn't mention the session, which could prove useful in the future if we want to use it in APIs allowing users to implement their own mass indexer
I renamed
SearchWritertoSearchWorkspace. The new name is still quite generic, but it makes more sense: a workspace is where work is done, it delimits what part of the indexes will affected.Also, this name would be suitable for a future zero-downtime indexing solution: by creating a workspace with specific parameters, a user could trigger the creation of a temporary workspaces targeting temporary indexes, which could ultimately replace the main indexes.