HSEARCH-4432 + HSEARCH-4433 + HSEARCH-4434 Upgrade to Hibernate ORM 5.4.33.Final #2831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yrodiere
commented
Jan 10, 2022
yrodiere
commented
- HSEARCH-4433: Upgrade to Log4j 2 in Hibernate Search 5.x tests
- HSEARCH-4434 (backport from HSEARCH-4434 Avoid unnecessary synchronization in ExpectedLog4jLog #2830): Avoid unnecessary synchronization in ExpectedLog4jLog
- HSEARCH-4432: Upgrade to Hibernate ORM 5.4.33.Final
yrodiere
force-pushed
the
HSEARCH-4433
branch
4 times, most recently
from
18d2208 to
78421de
Compare
Member
Author
|
Marking as draft until ORM 5.4.33*.Final* gets released (right now it's published under the wrong version number 5.4.33) cc @Sanne |
yrodiere
force-pushed
the
HSEARCH-4433
branch
2 times, most recently
from
deaf5da to
b893257
Compare
…root logger Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…n an ExpectedLog4jLog assertion fails If we don't use toImmutable(), the event can be reused and its message erased. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
…ling ExpectedLog4jLog assertion Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Because we sometimes check logs that are added concurrently from multiple threads, and if we aren't careful about being thread-safe, we can miss some log events. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
yrodiere
force-pushed
the
HSEARCH-4433
branch
from
b893257 to
da6ddfd
Compare
Member
|
It's released |
Member
Author
|
Thanks @Sanne ; I restarted the CI job to test the upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.