Skip to content

Conversation

@yrodiere
Copy link
Member

@yrodiere yrodiere requested a review from fax4ever January 11, 2022 10:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@fax4ever fax4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

* the custom settings/mapping are parsed.
*/
@Test
@TestForIssue(jiraKey = {"HSEARCH-4435"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor stuff: usually we don't put the curly brackets around the jira key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, probably some IDE auto-complete gone wrong. Well, I'll be more careful next time; no need to bother CI with such a change.

@yrodiere yrodiere merged commit e6faf0b into hibernate:main Jan 11, 2022
@yrodiere
Copy link
Member Author

Merged, thanks

@yrodiere yrodiere deleted the HSEARCH-4435 branch January 18, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants