Skip to content

Conversation

@Vyom-Yadav
Copy link
Contributor

Didn't open an issue in Jira for it.
Related Issue- checkstyle/checkstyle#11268
Related PR- checkstyle/checkstyle#11270

Every member class or interface declaration in the body of an interface declaration is implicitly public and static. See JLS for more info.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Feb 5, 2022

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@romani
Copy link

romani commented Feb 5, 2022

@yrodiere, can you help us with this PR ?
Do we need issue for such cleanup ? May be there is already ongoing issue

@yrodiere yrodiere changed the title Remove redundant public modifier reported by checkstyle HSEARCH-4479 Remove redundant public modifier reported by checkstyle Feb 7, 2022
@yrodiere yrodiere force-pushed the CS-HibSearch-RedundantMod branch from 87ba860 to 40f2a40 Compare February 7, 2022 07:59
@yrodiere
Copy link
Member

yrodiere commented Feb 7, 2022

Thanks!

I created HSEARCH-4479 to track this and added the ticket key to the commit message.

I'll merge as soon as CI passes.

@yrodiere yrodiere merged commit 113c9cd into hibernate:main Feb 7, 2022
@yrodiere
Copy link
Member

yrodiere commented Feb 7, 2022

On second thought, given the nature of the change, I'll merge it right now :) Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants