'navigation' not implemented..?

[maxxpower007]

Hi,

I am trying to change the export icon (and add others) to a font icon.
To do this I need to set allowHTML in the 'navigation' part, however, it doesn't seem to get converted:

Eg:

hc_options = {
    'navigation': {
        'buttonOptions': {
            'useHTML': True
        }
    },
    'exporting': {
        'buttons': {
            'contextButton': {
                'enabled': False
            },
            'exportButton': {
                'text': '<i class="fa fa-download"></i>',
                'onclick': 'function () { this.exportChart(); }'
            }
        }
    }
}
chart = Chart(options=hc_options)
chart.to_dict()

Yields (notice the missing 'navigation'):

{'userOptions': {'exporting': {'buttons': {'contextButton': {'enabled': False}, 'exportButton': {'text': '<i class="fa fa-download"></i>'}}}}}

[hcpchris]

Hi @maxxpower007 : Thanks for reporting this! I took a quick look, and it seems to be the same / very similar issue as in #84 : the buttonOptions property is mapping to the incorrect base-class, which is causing buttonOptions to get dropped (and in your example, that means that navigation is empty, which means that it gets trimmed out of the result).

I'll take a closer look and patch this in v.1.3.3 which will go out today - this should have been caught in yesterday's bugfix for #84 , but it looks to have slipped through the cracks.

[hcpchris]

Just confirming, there was a bug, and it was similar (though not the same) as in #84. The bug has been fixed in v.1.3.3 which was just released, and so the navigation.buttonOptions should no longer be dropped during serialization.

[maxxpower007]

Perfect..!
Confirmed working..

[maxxpower007]

Half working.. :)

hc_options = {
    'navigation': {
        'buttonOptions': {
            'theme': {
                'style': {
                    'fontSize': '30px',
                    'color': '#888'
                },
                'states': {
                    'hover': {
                        'style': {
                            'color': '#000'
                        }
                    }
                }
            },
            'useHTML': True
        }
    }
}
chart = Chart(options=hc_options)
chart.to_dict()

Yields (notice the missing theme):

{'userOptions': {'navigation': {'buttonOptions': {'useHTML': True}}}}

[hcpchris]

Hrm. Looks like there's an issue in the ButtonTheme class. I'll take a closer look tomorrow and do a deep dive on the whole Navigation module - clearly looks like some things were missed in there (and that our testing missed - the unit tests I checked today covered the ButtonTheme class, so there must be something odd happening in there). Either way - I'll do a deeper dive over the weekend. Sorry for the trouble!

[maxxpower007]

Not a big issue... I should probably be using css styling to theme anyways.
Cheers