Skip to content

Conversation

ayewo
Copy link
Contributor

@ayewo ayewo commented Feb 13, 2024

This PR fixes1 highlight/highlight#7691

/claim highlight/highlight#7691

Footnotes

  1. playing with the edit button because the Algora bot didn’t pick up that I submitted a PR that closed the issue.

@ayewo ayewo changed the title [WIP] feat: setup CI for the PHP SDK feat: setup CI for the PHP SDK Feb 14, 2024
@ayewo ayewo marked this pull request as ready for review February 14, 2024 21:26
@ayewo
Copy link
Contributor Author

ayewo commented Feb 17, 2024

@Vadman97 please take a look when you have a moment.

@Vadman97 Vadman97 self-requested a review February 20, 2024 18:16
Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! could we ge the PR to run the checks to make sure they are good to go?

Co-authored-by: Vadim Korolik <vkorolik@gmail.com>
@Vadman97
Copy link
Member

@ayewo is it possible to run this check in your fork to validate that it's working?

@ayewo
Copy link
Contributor Author

ayewo commented Feb 21, 2024

Thanks for your review!

nice! could we ge the PR to run the checks to make sure they are good to go?

If by "run the checks" you are referring to a way to trigger GitHub Actions on the .github/workflows/ci.yml file, it wont work yet until you merge the code :)

If OTOH you are referring to the tests, this is already the case in .github/workflows/ci.yml where line 31 executes composer test which calls the tests.

@ayewo
Copy link
Contributor Author

ayewo commented Feb 21, 2024

@ayewo is it possible to run this check in your fork to validate that it's working?

@Vadman97
Here's a link to the run I triggered just now in my fork:
https://github.com/ayewo/highlight-php/actions/runs/7951988402/job/21837310205

@Vadman97 Vadman97 merged commit bf0fdc3 into highlight:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants