(javascript) Incorrect highlight after '/' symbol

[gdmfilippov]

Describe the issue
In some cases, the highlight is not correct after the '/' symbol.
Bellow is 2 examples.

Which language seems to have the issue?*
javascript

Are you using highlight or highlightAuto?
highlight

Sample Code to Reproduce
Example 1:

const x = `${duration / 1000}`;
func();

Example 2:

a(b, /.*c.*/);
func();

Expected behavior
In the example 1, the text after the '/' symbol doesn't change highlight color (including the symbol itself)

In the example 2 highlight after regexp must be correct

Additional context
It seems, problem appears in 9.18.1. I can't reproduce the problem with 9.18.2

[joshgoebel]

It seems, problem appears in 9.18.1. I can't reproduce the problem with 9.18.2

Please confirm you are actually having this problem with the latest release, 10.0.2.

[joshgoebel]

If you can test #2531, please do.

[joshgoebel]

Nope that just shifts it, the problem is that value container and attr container are both fighting for this content...

[joshgoebel]

Where else is the ident:as in \b[ident][colon] pattern used in JS other than object keys? If we just removed the attr container and looked for keys anywhere, what would that break?

[joshgoebel]

Answer: ternary, lol.

key4: false ? undefined : true

Right there in the test file too, LOL.

[joshgoebel]

FYI: Example 1 should not ben an issue in version 10, can you confirm?

[joshgoebel]

      { // object attr container
        begin: regex.concat(/[{,\n]\s*/,
          // we need to look ahead to make sure that we actually have an
          // attribute coming up so we don't steal a comma from a potential
          // "value" container
          regex.lookahead(regex.concat(
            // we also need to allow for multiple possible comments inbetween
            // the first key:value pairing
            /(\/\/.*\s*)*/,
            IDENT_RE + '\\s*:'))),

That's one way to get it done...

[joshgoebel]

Probably also needs to check multi-line comments.

[gdmfilippov]

FYI: Example 1 should not ben an issue in version 10, can you confirm?

Example 1 has an issue in version 10, but example 2 - not:
Version 9.18.1: https://jsfiddle.net/j35arp2d/11/
Version 10.0.2: https://jsfiddle.net/2us07vdh/1/

If you can test #2531, please do.
Will try to test in 24 hours

[joshgoebel]

Example 1 has an issue in version 10, but example 2 - not:

I see the opposite. In version 10 example 1 looks great while example 2 is broken.