Skip to content

fix(c-like) Correctly highlight modifiers in class declaration (#2696) #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020
Merged

fix(c-like) Correctly highlight modifiers in class declaration (#2696) #2698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6fe29e
fix(c-like) Correctly highlight modifiers in class declaration (#2696)
joshgoebel Sep 21, 2020
1e0cee4
Update CHANGES.md
joshgoebel Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Language Improvements:
- fix(csharp) prevent modifier keywords wrongly flagged as `title` (#2683) [Josh Goebel][]
- enh(axapta) Update keyword list for Axapta (X++) (#2686) [Ryan Jonasson][]
- fix(fortran) FORTRAN 77-style comments (#2677) [Philipp Engel][]
- fix(c-like) Correctly highlight modifiers (`final`) in class declaration (#2696) [Josh Goebel][]

[David Pine]: https://github.com/IEvangelist
[Josh Goebel]: https://github.com/yyyc514
Expand Down
1 change: 1 addition & 0 deletions src/languages/c-like.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export default function(hljs) {
className: 'class',
beginKeywords: 'class struct', end: /[{;:]/,
contains: [
{ beginKeywords: "final" },
{begin: /</, end: />/, contains: ['self']}, // skip generic stuff
hljs.TITLE_MODE
]
Expand Down