Skip to content

Commit d0b9c7e

Browse files
More fixes for running python tests in coverage testing mode.
1 parent a2d058f commit d0b9c7e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Makefile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -444,13 +444,13 @@ ifeq ($(OS),Darwin)
444444
cp pyminsky.so gui-js/build/
445445
else
446446
ifndef MXE
447-
$(LINK) -shared -o $@ $^ libminsky.a $(RPATH) $(LIBS)
447+
$(LINK) -shared $(FLAGS) -o $@ $^ libminsky.a $(RPATH) $(LIBS)
448448
endif
449449
endif
450450

451451
# used to find undefined symbols in pyminsky.so
452452
pyminsky-test: test/testmain.o pyminsky.o libminsky.a
453-
$(LINK) -o $@ $^ $(LIBS) -lpthread -ltirpc
453+
$(LINK) $(FLAGS) -o $@ $^ $(LIBS) -lpthread -ltirpc
454454

455455
RESTService/dummy-addon.node: dummy-addon.o $(NODE_API)
456456
ifdef MXE
@@ -547,14 +547,15 @@ dist:
547547
js-dist:
548548
sh makeJsDist.sh
549549

550+
LCOV_FLAGS=--no-external --ignore-errors gcov,mismatch,wrap,version
550551
lcov:
551552
$(MAKE) clean
552-
-$(MAKE) GCC=1 GCOV=1 tests
553-
lcov -i -c -d . --no-external -o lcovi.info
553+
-$(MAKE) GCC=1 GCOV=1 tests python3
554+
lcov -i -c -d . $(LCOV_FLAGS) -o lcovi.info
554555
# ensure schema export code is exercised
555556
-$(MAKE) GCOV=1 minsky.xsd
556557
-$(MAKE) GCOV=1 sure
557-
lcov -c -d . --no-external -o lcovt.info
558+
lcov -c -d . $(LCOV_FLAGS) -o lcovt.info
558559
lcov -a lcovi.info -a lcovt.info -o lcov.info
559560
lcov -r lcov.info */ecolab/* "*.cd" "*.xcd" "*.rcd" "*.tcd" -o lcovr.info
560561
genhtml -o coverage lcovr.info

RESTService/pyminsky.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
// TODO figure out how to switch buffer types... For now, use JSON
2121
//#define REST_PROCESS_BUFFER classdesc::PythonBuffer
2222
#include "minsky.h"
23+
#include "CSVTools.xcd"
2324
#include "minsky_epilogue.h"
2425
#include "pythonBuffer.h"
2526

0 commit comments

Comments
 (0)