Skip to content

Conversation

@johnlanni
Copy link

@johnlanni johnlanni commented Nov 11, 2025

  • Add rebuild mechanism for WasmHandle and PluginHandle with shouldRebuild flag
  • Fix wasi_unstable_path_rename signature to include new_path_len parameter
  • Rename doRecover to rebuild for better clarity
  • Add destructor cleanup with clearWasmInContext
  • Code formatting improvements

🤖 Generated with [Qoder][https://qoder.com]

Co-developed-by: Claude noreply@anthropic.com


Note

Introduce proactive rebuild for Wasm VM and plugin handles (replacing doRecover), add rebuild flag and cleanup on destruction, and correct WASI path_rename signature.

  • Runtime/Core:
    • Add rebuild flow: rename WasmHandleBase::doRecover/PluginHandleBase::doRecover to rebuild and wire new callbacks.
    • Introduce WasmBase::should_rebuild_ with shouldRebuild()/setShouldRebuild() to support proactive rebuild; update recover callbacks to honor/reuse or recreate accordingly and add error logs.
    • Call clearWasmInContext() in WasmBase destructor to prevent stale context references.
    • Minor refactors/formatting in restricted callback setup and logging.
  • WASI/API:
    • Fix wasi_unstable_path_rename signature to include new_path_len and update declaration/registration macros.
    • Minor comment/formatting tweaks; keep stubs behavior consistent.
  • Tests:
    • Update tests to use rebuild API and validate rebuild/reuse behavior across plugin/VM failures.

Written by Cursor Bugbot for commit a01eb3c. This will update automatically on new commits. Configure here.

- Add rebuild mechanism for WasmHandle and PluginHandle with shouldRebuild flag
- Fix wasi_unstable_path_rename signature to include new_path_len parameter
- Rename doRecover to rebuild for better clarity
- Add destructor cleanup with clearWasmInContext
- Code formatting improvements

🤖 Generated with [Qoder][https://qoder.com]

Signed-off-by: zty98751 <zty98751@alibaba-inc.com>
Co-developed-by: Claude <noreply@anthropic.com>
@johnlanni johnlanni merged commit 04ef279 into higress-group:master Nov 11, 2025
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant