Skip to content

Fix / CLOUD-25858 / header menu button aria-label #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix / CLOUD-25858 / header menu button aria-label #14

merged 2 commits into from
Sep 5, 2024

Conversation

@oli-hivemq
Copy link
Collaborator

@oli-hivemq oli-hivemq commented Sep 5, 2024 •
edited
Loading

Why

Header.MenuButton doesn't use aria-label the right way, which generates errors in the console.

What

  • Replace ariaLabel by aria-label.
  • bump version of ui-theme to 0.4.2

Todos

  • I have added a description to this pull request that describes the changes in detail
  • I have performed a self-review of my code
  • I have added a label that describes the PR type (bug, enhancement, ci, refactor, documentation, test, chore)
  • I have updated the optional PR title to follow the pattern Fix / TICKET_ID / DESCRIPTION (e.g. Fix / 123456 / Fixing the login button)
  • I have run manual tests to check if everything is functional
  • I have added screenshots/videos that explain my graphical changes

Screenshots

@oli-hivemq oli-hivemq added the bug Something isn't working label Sep 5, 2024
@oli-hivemq oli-hivemq self-assigned this Sep 5, 2024
@oli-hivemq oli-hivemq added the bump label Sep 5, 2024
antpaw
antpaw approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@antpaw antpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@oli-hivemq oli-hivemq merged commit 6188b85 into main Sep 5, 2024
@oli-hivemq oli-hivemq deleted the fix/CLOUD-25858/header-menu-button-aria branch September 5, 2024 14:04
@oli-hivemq oli-hivemq mentioned this pull request Sep 5, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antpaw antpaw antpaw approved these changes

@h2xd h2xd Awaiting requested review from h2xd

Assignees

@oli-hivemq oli-hivemq

Labels

bug Something isn't working bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oli-hivemq @antpaw