Skip to content

Conversation

@antpaw
Copy link
Collaborator

@antpaw antpaw commented Sep 27, 2024

Why

i run into vitest issues as vite can not figure out what to import, remove this common js artifact will simplify it, common js is deprecated and will be removed anyway

What

updated the vite build settings and the package.json links

@antpaw antpaw requested a review from h2xd as a code owner September 27, 2024 13:25
@antpaw antpaw self-assigned this Sep 27, 2024
@h2xd
Copy link
Contributor

h2xd commented Sep 27, 2024

👍 from my end.
I do not see any common.js use-cases as most new examples and bootstrap tools include Vite and ECMAScript by now.

@antpaw antpaw merged commit 9783573 into main Oct 2, 2024
7 checks passed
@antpaw antpaw deleted the remove-common-js-format branch October 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants