Skip to content

Conversation

@FlandiaYingman
Copy link

Fix #274.

This PR fixes

module M with
  fun f(using Int, Int) = 42

which used to parse the using Int part only but failed to parse the (second) Int part.

Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the following syntaxes work? Do we have tests for them?

fun foo(using Int, arg: Str)

fun foo(using arg: Str, Int)

FlandiaYingman and others added 3 commits February 11, 2025 21:18
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
@FlandiaYingman
Copy link
Author

Does the following syntaxes work? Do we have tests for them?

fun foo(using Int, arg: Str)

fun foo(using arg: Str, Int)

They work fine and I just added them to the tests.

Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LPTK LPTK merged commit 7fbe62c into hkust-taco:hkmc2 Feb 11, 2025
1 check passed
@FlandiaYingman FlandiaYingman deleted the fix-contextual-param-syntax branch February 12, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants