Ngr 1126 - Adding Page Rent Interim Court details #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
app/uk/gov/hmrc/ngrraldfrontend/controllers/InterimRentSetByTheCourtController.scala
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/controllers/InterimRentSetByTheCourtController.scala
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/models/forms/CommonFormValidators.scala
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/models/forms/CommonFormValidators.scala
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/models/forms/InterimRentSetByTheCourtForm.scala
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/views/InterimRentSetByTheCourtView.scala.html
Outdated
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/views/InterimRentSetByTheCourtView.scala.html
Outdated
Show resolved
Hide resolved
test/uk/gov/hmrc/ngrraldfrontend/controllers/InterimRentSetByTheCourtControllerSpec.scala
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/models/forms/InterimRentSetByTheCourtForm.scala
Show resolved
Hide resolved
app/uk/gov/hmrc/ngrraldfrontend/models/forms/ProvideDetailsOfFirstSecondRentPeriodForm.scala
Show resolved
Hide resolved
|
|
||
| import play.api.libs.json.{Json, OFormat} | ||
|
|
||
| case class InterimRentSetByTheCourt(amount: String, |
There was a problem hiding this comment.
Can you please add spec for this?
| regexp(amountRegex.pattern(), howMuchFormatError) | ||
| ) | ||
| ) | ||
| .transform[BigDecimal](BigDecimal(_).setScale(2, RoundingMode.UP), _.toString) |
There was a problem hiding this comment.
You probably need to change to RoundingMode.HALF_UP. Because RoundingMode.UP will round up even it's less than 5. Ex. 3.3 will become 4.
There was a problem hiding this comment.
even with the half round it still dropping the last decimal
| "insert interim rent amount and start date" in { | ||
| await(repository.insertInterimRentSetByTheCourt(credId, 10000.00, "2020-1")) | ||
| val actual = await(repository.findByCredId(credId)) | ||
| actual shouldBe Some(RaldUserAnswers(credId, NewAgreement, property, interimRentSetByTheCourt = Some(InterimRentSetByTheCourt(amount = "10000.0", date = "2020-1")))) |
There was a problem hiding this comment.
This doesn't feel right for me. I checked that BigDecimal from your form is scale to 2. But toString is missing one decimal. What do you think?
JakeReid2020
force-pushed
the
NGR-1126
branch
from
226fda9 to
7403545
Compare
|
anna-shen-hmrc
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.