-
Notifications
You must be signed in to change notification settings - Fork 31
chore: remove mentions of hc-launch from docs; instruct to remove in 0.6 upgrade guide #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughSwitch documentation and examples from a dual-tool dev workflow (hc-launch/tauri + hc-spin) to a single hc-spin workflow: remove hc-launch/tauri references and scripts, update install and WSL guidance, adjust happ launch options (bootstrap/signaling/network-seed), and add build changes (RUSTFLAGS) and hc-spin version bump. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-08-28T23:39:06.675ZApplied to files:
🪛 LanguageToolsrc/pages/get-started/install-advanced.md[style] ~156-~156: Consider a more concise word here. (IN_ORDER_TO_PREMIUM) 🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…0.6 upgrade guide
d9dfc37 to
43c70d4
Compare
| Some Holochain runtimes bundle the conductor and a front end host that serves your HTML/JavaScript-based runtimes. Take a look at the [Packaging and Distribution](/get-started/4-packaging-and-distribution/) page from the Get Started guide for the choices. | ||
|
|
||
| The Holonix dev environment comes with a runtime called `hc-launch`, which starts Holochain, installs your hApp, and displays a UI for you. The scaffolding tool generates an NPM script that compiles and bundles your back end into a [`.happ` file](/build/happs/#package-a-happ-for-distribution) and starts two instances of the hApp with `hc-launch`. In the root of your project folder, enter: | ||
| The Holonix dev environment comes with a runtime called `hc-spin`, which starts a Holochain conductor, installs your hApp into it, and displays a UI for you. The scaffolding tool generates an NPM script that compiles and bundles your back end into a [`.happ` file](/build/happs/#package-a-happ-for-distribution) and starts two instances of the hApp with `hc-spin`. In the root of your project folder, enter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's not really correct that hc-spin is part of Holonix. It's an npm package that gets scaffolded into the package.json.
|
✔️ 43c70d4...3a55037 - Conventional commits check succeeded. |
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.