Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set interactive function to lazy to avoid calling it twice #772

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 8, 2022

Splits up the fixes in #768 as this change is unrelated to the warning.

I have commented out part of the test related to the changes in #768, that PR should uncomment those lines.

hoxbro added a commit to hoxbro/hvplot that referenced this pull request Jul 8, 2022
hoxbro added a commit to hoxbro/hvplot that referenced this pull request Jul 8, 2022
@hoxbro
Copy link
Member Author

hoxbro commented Jul 8, 2022

The failing tests were related to a data file no longer being at the https://github.com/mapbox/rasterio/raw/master/tests/data/RGB.byte.tif, but here https://github.com/rasterio/rasterio/raw/main/tests/data/RGB.byte.tif. A change from master --> main.

I did add the data file to the commit instead of using the URL as before to avoid having a problem like this in the future. But I'm wondering if this could affect the package size and if I should go back to using the URL.

@jbednar
Copy link
Member

jbednar commented Jul 8, 2022

1.67MB does seem like a lot just to get an example image, but I'm not sure what fraction of the overall package that represents. Maybe instead of using either master or main, use a specific revision's tag?

@hoxbro
Copy link
Member Author

hoxbro commented Jul 8, 2022

What if I exclude the file in MANIFEST.in? I can then, in a follow-up PR, change the path to a hvplot URL.

That way, we have complete control over the file and the data in it, and people will still be able to run the test locally.

@philippjfr
Copy link
Member

Can we use a more minimal tif file?

@hoxbro
Copy link
Member Author

hoxbro commented Jul 11, 2022

Can we use a more minimal tif file?

Properly, but I don't know how comprehensive it will be to create and update the code. I will change it back to a URL and make an issue about updating the test file.

@maximlt maximlt added this to the 0.8.1 milestone Jul 18, 2022
@maximlt
Copy link
Member

maximlt commented Jul 21, 2022

This looks good to me, thanks!

@maximlt maximlt merged commit 8c150fd into holoviz:master Jul 21, 2022
@hoxbro hoxbro deleted the lazy_panel_interactive branch July 22, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants