Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the html theme to use sphinx_holoviz_theme #390

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Conversation

kebowen730
Copy link
Contributor

@philippjfr @jlstevens I updated the conf.py file to use sphinx_holoviz_theme

@coveralls
Copy link

coveralls commented Apr 10, 2020

Coverage Status

Coverage remained the same at 76.237% when pulling 73e7206 on update-sphinx into 08c2d44 on master.

@ceball
Copy link
Member

ceball commented Apr 13, 2020

I'm totally no longer competent to review this stuff, but what about https://github.com/holoviz/param/blob/master/.travis.yml#L131 - does it need to be updated too?

(Such dependencies should be in setup.py where people might have a chance of finding them...)

@ceball ceball added the doc docs, interactive help, auto-completion, etc label Apr 13, 2020
@ceball
Copy link
Member

ceball commented Apr 14, 2020

@kebowen730 Like I said, I'm not sure how this all works any more, but I can't immediately think of what else you'd need to change, so I'll merge. Could you then try pushing the appropriate tag to get a dev website re-build to happen (i.e. to update https://pyviz-dev.github.io/param) and check the build works and the site comes out ok?

I don't know if this general pattern (i.e. how to rebuild our sites) is documented somewhere. If not, it would be great to capture it somewhere.

Thanks!

@ceball ceball merged commit 6044a86 into master Apr 14, 2020
@kebowen730 kebowen730 deleted the update-sphinx branch May 5, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc docs, interactive help, auto-completion, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants