Ensure that Parameterized remaps watchers on copy #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Parameterized is (deep)copied the watchers on it are copied along with the rest of the internal state. The problem with this is that these watchers will still call methods on the original, not on the copy. Therefore we have to override
__setstate__
behavior to detect internal watchers (i.e. methods on the instance and those set up by decorating methods using@param.depends(..., watch=True)
) and correctly copy them.Fixes #407
Ping @sdc50