Add light platform to qbus

[thomasddn]

Proposed change

Add support for light platform to the qbus integration. Because of that, a function has been moved so it can be used by several platforms.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add light platform to qbus home-assistant.io#37033

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Qbus-iot, mind taking a look at this pull request as it has been labeled with an integration (qbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of qbus can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign qbus Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[davet2001]

As far as my understanding goes, this looks good.

One question I had was whether Qbus dimmers have a separate on/off state as well as the dimmer state.

For example is setting dimmer to 0% the same as turning it off? For some integrations in those cases the dimmer is active but at a very low brightness which is usually not what people want (energy use, heat output, sometimes sound etc).

I looked at the QBus documentation for a short time but couldn't find this out either way.

Another way of asking is whether the QBusMqttOnOffState can be set for a dimmer. Do you know?

[thomasddn]

Hi! We discussed this internally and you are actually right about on/off! Setting the value to 0% does turn the dimmer off. But using the on command will turn the dimmer on with the preconfigured value.

I'll update the code.

[thomasddn]

Code has been updated

[thomasddn]

Some voip test failed. Should I rebase the latest dev version?

[davet2001]

As you say, the failure was unrelated. I just reran the test and it passed, so no need to rebase. Thanks!

[davet2001]

Looks good to me!
Thanks @thomasddn!

[thomasddn]

Just wondering, no pressure: am I supposed to do something or are we waiting until after the February release? Sorry, I'm not sure how this typically works.

[davet2001]

@thomasddn nothing more needed from you, it's on us now!

I'll request a 2nd opinion before merging in case I missed something.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[thomasddn]

Hi! A few things were changed after a second opinion review. Are we able to merge now?

Addressed