Skip to content

Use xmod model info for Shelly XMOD devices#137013

Merged
chemelli74 merged 14 commits intohome-assistant:devfrom
chemelli74:chemelli74-shelly-rpc-model
Feb 19, 2025
Merged

Use xmod model info for Shelly XMOD devices#137013
chemelli74 merged 14 commits intohome-assistant:devfrom
chemelli74:chemelli74-shelly-rpc-model

Conversation

@chemelli74
Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 commented Jan 31, 2025

Proposed change

Small improvement in order to use the model property from upstream library

Needs home-assistant-libs/aioshelly#775

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are test failure related to this change. Would you take a look at those?

@home-assistant home-assistant Bot marked this pull request as draft January 31, 2025 16:52
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@chemelli74 chemelli74 changed the title Use aioshelly model property for Shelly RPC devices Use xmod model info for Shelly XMOD devices Feb 1, 2025
@chemelli74 chemelli74 marked this pull request as ready for review February 9, 2025 12:53
Comment thread homeassistant/components/shelly/utils.py Outdated
Comment thread homeassistant/components/shelly/utils.py Outdated
Copy link
Copy Markdown
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested with real device. Thanks 👍

@chemelli74 chemelli74 merged commit 901011d into home-assistant:dev Feb 19, 2025
@chemelli74 chemelli74 deleted the chemelli74-shelly-rpc-model branch February 19, 2025 21:47
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants