Skip to content

Make Sonos action descriptions more UI- and translation-friendly#137356

Merged
abmantis merged 1 commit intohome-assistant:devfrom
NoRi2909:patch-375878
Feb 4, 2025
Merged

Make Sonos action descriptions more UI- and translation-friendly#137356
abmantis merged 1 commit intohome-assistant:devfrom
NoRi2909:patch-375878

Conversation

@NoRi2909
Copy link
Copy Markdown
Contributor

@NoRi2909 NoRi2909 commented Feb 4, 2025

Proposed change

This PR changes several descriptions in the Sonos actions to better reflect the UI context (toggles for true / false, e.g.)

In addition it adds a few words and details from the online docs for more helpful translations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This commit changes several descriptions in the Sonos actions to better reflect the UI context (toggles for true / false, e.g.)

In addition it adds a few words and details from the online docs for more helpful translations.
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Feb 4, 2025

Hey there @jjlawren, @PeteRager, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sonos can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sonos Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abmantis abmantis merged commit 94f6daa into home-assistant:dev Feb 4, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2025
@NoRi2909 NoRi2909 deleted the patch-375878 branch February 7, 2025 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants