Skip to content

squeezebox bump pysqueezebox to 0.12.0#138205

Merged
edenhaus merged 2 commits intohome-assistant:devfrom
pssc:squeezebox-pysqueezebox
Feb 14, 2025
Merged

squeezebox bump pysqueezebox to 0.12.0#138205
edenhaus merged 2 commits intohome-assistant:devfrom
pssc:squeezebox-pysqueezebox

Conversation

@pssc
Copy link
Copy Markdown
Contributor

@pssc pssc commented Feb 10, 2025

Proposed change

Bump supporting library to 0.12.0 pysqueezebox

https://github.com/rajlaud/pysqueezebox/releases/tag/v0.12.0

This will allow us to simplify the code in HA relating to the squeezebox integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: squeezebox small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Feb 10, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @rajlaud, @peteS-UK, mind taking a look at this pull request as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of squeezebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign squeezebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@CloCkWeRX
Copy link
Copy Markdown
Contributor

Please run python3 -m script.gen_requirements_all

@CloCkWeRX
Copy link
Copy Markdown
Contributor

Okay, this seems ready - just needs a few more things in the pr template ticked and a description, then would be ready for review

@pssc pssc marked this pull request as ready for review February 13, 2025 20:41
Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pssc 👍

@edenhaus edenhaus merged commit 83f8a44 into home-assistant:dev Feb 14, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: squeezebox Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants