Skip to content

Bump env_canada to 0.8.0#138237

Merged
frenck merged 4 commits intohome-assistant:devfrom
maruel:bump_env_canada
Mar 1, 2025
Merged

Bump env_canada to 0.8.0#138237
frenck merged 4 commits intohome-assistant:devfrom
maruel:bump_env_canada

Conversation

@maruel
Copy link
Copy Markdown
Contributor

@maruel maruel commented Feb 10, 2025

Proposed change

Bump env_canada.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: environment_canada small-pr PRs with less than 30 lines. Quality Scale: No score labels Feb 10, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @gwww, @michaeldavie, mind taking a look at this pull request as it has been labeled with an integration (environment_canada) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of environment_canada can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign environment_canada Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gwww
Copy link
Copy Markdown
Contributor

gwww commented Feb 10, 2025

Looks good to me.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing, can you take a look?

Thanks! 👍

../Frenck

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft February 11, 2025 10:48
@maruel maruel marked this pull request as ready for review February 12, 2025 17:59
@home-assistant home-assistant Bot requested a review from frenck February 12, 2025 18:00
@maruel
Copy link
Copy Markdown
Contributor Author

maruel commented Feb 12, 2025

The CI is failing, can you take a look?

Apologies for not grepping properly.

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 12, 2025

Apologies for not grepping properly.

Grepping? We have tooling for this. Essentially, you shouldn't have been able to commit it wrongly in the first place (as the pre-commit would fail). Which makes me wonder: How did you test this PR?

../Frenck

@frenck frenck marked this pull request as draft February 12, 2025 18:02
@maruel
Copy link
Copy Markdown
Contributor Author

maruel commented Feb 12, 2025

I modified my docker installation to run Home Assistant with the new version, confirming the bug in the dependency was fixed as the error went away from Home Assistant's logs.

@frenck frenck added this to the 2025.3.0 milestone Feb 28, 2025
@frenck frenck marked this pull request as ready for review March 1, 2025 12:09
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maruel 👍

../Frenck

@frenck frenck merged commit 9fe08f2 into home-assistant:dev Mar 1, 2025
bramkragten pushed a commit that referenced this pull request Mar 2, 2025
* Bump env_canada to 0.8.0

* Fix requirements*.txt

* Grepped more

---------

Co-authored-by: Franck Nijhof <git@frenck.dev>
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2025
@maruel maruel deleted the bump_env_canada branch June 27, 2025 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maps.geogratis.gc.ca doesn't resolve anymore

5 participants