Skip to content

Remove question marks and "true/false" from action fields in zwave_js#138263

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
NoRi2909:patch-5
Feb 11, 2025
Merged

Remove question marks and "true/false" from action fields in zwave_js#138263
MartinHjelmare merged 1 commit intohome-assistant:devfrom
NoRi2909:patch-5

Conversation

@NoRi2909
Copy link
Copy Markdown
Contributor

@NoRi2909 NoRi2909 commented Feb 11, 2025

Proposed change

  • change three field names from a question to just a name
  • remove "true" / "false" to reflect that these are toggles in the UI

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

- change three field names from a question to just a name
- remove "true" / "false" to reflect that these are toggles in the UI
@NoRi2909 NoRi2909 requested a review from a team as a code owner February 11, 2025 08:20
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare merged commit a4decab into home-assistant:dev Feb 11, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 12, 2025
@NoRi2909 NoRi2909 deleted the patch-5 branch February 14, 2025 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants