Add flag to backup store to track backup wizard completion#138368
Merged
MartinHjelmare merged 6 commits intodevfrom Feb 24, 2025
Merged
Add flag to backup store to track backup wizard completion#138368MartinHjelmare merged 6 commits intodevfrom
MartinHjelmare merged 6 commits intodevfrom
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
commented
Feb 12, 2025
Member
|
Side note: Just a general note that we should never use a parameter as input to logic for a different thing than the parameter purpose. This is classic lazy design that always comes back and hurts us. |
MartinHjelmare
approved these changes
Feb 12, 2025
Member
|
Drafting while we are awaiting the frontend. /CC @bramkragten |
Merged
9 tasks
Member
|
Frontend is approved |
Contributor
Author
|
hassio tests need to be updated |
MartinHjelmare
approved these changes
Feb 24, 2025
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add flag to backup store to track backup wizard completion
Frontend currently checks if a password has been set to track completion of the backup wizard, unfortunately that means it's possible to create a new key, view it, print the pdf, but that key is in the end not used if the user doesn't complete the wizard.
By adding a wizard completion flag, this behavior can be fixed so a newly created password is immediately saved.
Type of change
Additional information
automatic_backups_configuredflag to signal if backup onboardin… frontend#24367Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: